HW-51698 add paypal account status transitions java #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseveryn-hw
reviewed
Nov 28, 2019
| transition.setCreatedOn(null); | ||
| transition.setFromStatus(null); | ||
| transition.setToStatus(null); | ||
| return apiClient.post(url + "/users/" + userToken + "/PayPal-accounts/" + payPalAccountToken + "/status-transitions", transition, HyperwalletStatusTransition.class); |
There was a problem hiding this comment.
why do we need upper case in url, instead of "/paypal-accounts/"
There was a problem hiding this comment.
I was confused with incorrect example, I have already corrected it
aseveryn-hw
reviewed
Nov 28, 2019
| } | ||
|
|
||
| @Test | ||
| public void testDeactivatePayPalAccountStatusTransition_noPaperCheckToken() throws Exception { |
igusar-epam
approved these changes
Dec 4, 2019
aseveryn-hw
reviewed
Dec 4, 2019
| * Deactivate a PayPal Account | ||
| * | ||
| * @param userToken User token | ||
| * @param payPalAccountToken PayPal Account token |
There was a problem hiding this comment.
@param notes is missing here
aseveryn-hw
reviewed
Dec 4, 2019
| * | ||
| * @param userToken User token | ||
| * @param payPalAccountToken PayPal Account token | ||
| * @return The status transition |
There was a problem hiding this comment.
@return HyperwalletStatusTransition deactivated PayPal account
aseveryn-hw
reviewed
Dec 4, 2019
| } | ||
|
|
||
| @Test | ||
| public void testCreatePayPalAccountStatusTransition_noPaperCheckToken() { |
aseveryn-hw
reviewed
Dec 4, 2019
| } | ||
|
|
||
| @Test | ||
| public void testGetPayPalAccountStatusTransition_noPaperCheckToken() { |
aseveryn-hw
reviewed
Dec 4, 2019
| } | ||
|
|
||
| @Test | ||
| public void testListPayPalAccountStatusTransitions_noParameters_noPaperCheckToken() throws Exception { |
aseveryn-hw
reviewed
Dec 4, 2019
| } | ||
|
|
||
| @Test | ||
| public void testListPayPalAccountStatusTransitions_withParameters_noPaperCheckToken() throws Exception { |
There was a problem hiding this comment.
Fixed everything. Thank you a lot!
aseveryn-hw
approved these changes
Dec 4, 2019
gmeyer-hw
approved these changes
Dec 4, 2019
wmews-hw
approved these changes
Dec 5, 2019
wmews-hw
deleted the
HW-51698-add-paypal-account-status-transitions-java
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.site1.hyperwallet.local/browse/HW-51698