Changes for handling transfer refund in v4 endpoint #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…66626-V4-SDKTransferRefunds # Conflicts: # src/test/java/com/hyperwallet/clientsdk/HyperwalletTest.java
arao6
reviewed
Sep 2, 2020
| * Get Transfer Refund | ||
| * | ||
| * @param transferToken Transfer token assigned | ||
| * @param transferRefundToken Transfer Refund token assigned |
arao6
reviewed
Sep 2, 2020
| private HyperwalletTransferRefund copy(HyperwalletTransferRefund transferRefund) { | ||
| transferRefund = HyperwalletJsonUtil.fromJson(HyperwalletJsonUtil.toJson(transferRefund), HyperwalletTransferRefund.class); | ||
| return transferRefund; | ||
| } |
There was a problem hiding this comment.
Can be changed to: return HyperwalletJsonUtil.fromJson(HyperwalletJsonUtil.toJson(transferRefund), HyperwalletTransferRefund.class);
arao6
approved these changes
Sep 3, 2020
| } | ||
|
|
||
| transferRefund = copy(transferRefund); | ||
| transferRefund.setStatus(null); |
There was a problem hiding this comment.
can we use the clearStatus() method here?
There was a problem hiding this comment.
Changed as suggested.
|
|
||
| transferRefund = copy(transferRefund); | ||
| transferRefund.setStatus(null); | ||
| transferRefund.setCreatedOn(null); |
There was a problem hiding this comment.
Changed as suggested.
vkorotchenko
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.