Feature/hw 66628 v4 java sdk venmo account #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rrathinasabapath
approved these changes
Sep 1, 2020
arao6
reviewed
Sep 1, 2020
| * Get Venmo Account | ||
| * | ||
| * @param userToken User token assigned | ||
| * @param venmoAccountToken venmo Account token assigned |
There was a problem hiding this comment.
Upper case venmo Account.
In the below line too.
There was a problem hiding this comment.
Addressed it . thanks @arao6
arao6
reviewed
Sep 1, 2020
| * @param venmoAccountToken Venmo account token | ||
| * @param transition Status transition information | ||
| * @return HyperwalletStatusTransition new status for venmo Account | ||
| */ |
There was a problem hiding this comment.
changed to Uppercase
arao6
reviewed
Sep 1, 2020
| * @param userToken User token | ||
| * @param venmoAccountToken Venmo account token | ||
| * @return HyperwalletStatusTransition deactivated venmo account | ||
| */ |
# Conflicts: # src/test/java/com/hyperwallet/clientsdk/HyperwalletTest.java
peter-joseph
reviewed
Sep 2, 2020
| * Create Venmo Account | ||
| * | ||
| * @param venmoAccount HyperwalletVenmoAccount object to create | ||
| * @return HyperwalletVenmoAccount created venmo account for the specified user |
| } | ||
|
|
||
| private HyperwalletVenmoAccount copy(HyperwalletVenmoAccount venmoAccount) { | ||
| venmoAccount = HyperwalletJsonUtil.fromJson(HyperwalletJsonUtil.toJson(venmoAccount), HyperwalletVenmoAccount.class); |
There was a problem hiding this comment.
we can directly return from here if we are not going to use venmoAccount variable
peter-joseph
approved these changes
Sep 2, 2020
# Conflicts: # src/test/java/com/hyperwallet/clientsdk/util/HyperwalletApiClientTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.