Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Conversation

jkurra-hw
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Oct 5, 2020

Coverage Status

Coverage increased (+0.001%) to 99.657% when pulling 74c016f on feature/HW-67897-V3JavaSDK-UserStatusTransition into 3714f2a on support/SDK-V3.

pom.xml Outdated
<formats>
<format>xml</format>
<format>html</format>
</formats>
<maxmem>256m</maxmem>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jayaram, could you please remove this change from pom.xml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed . Thanks @arao6

Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add exception test cases for IT.

Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls update the 'verificationStatus' value list.

@@ -24,7 +24,7 @@

public static enum Status {PRE_ACTIVATED, ACTIVATED, LOCKED, FROZEN, DE_ACTIVATED}

public static enum VerificationStatus {UNDER_REVIEW, VERIFIED, REQUIRED, NOT_REQUIRED}
public static enum VerificationStatus {UNDER_REVIEW, VERIFIED, REQUIRED, NOT_REQUIRED, REQUESTED}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing statuses EXPIRED, READY_FOR_REVIEW and FAILED, run the tests again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added missing statuses and run the test cases working fine . Thanks @Rrathinasabapath

@jkurra-hw jkurra-hw requested a review from vkorotchenko October 6, 2020 19:27
Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine.

@akalichety-hw akalichety-hw merged commit d5a929a into support/SDK-V3 Oct 6, 2020
@arao6 arao6 deleted the feature/HW-67897-V3JavaSDK-UserStatusTransition branch February 1, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants