Fix response content type header check when content type header contains charset substring #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge updates
aseveryn-epam
force-pushed
the
fix-content-type-with-charset-header-check
branch
from
85ca715 to
d585eee
Compare
…ins charset substring
aseveryn-epam
force-pushed
the
fix-content-type-with-charset-header-check
branch
from
d585eee to
3cefaae
Compare
| callback(undefined, responseBody, decryptedData); | ||
| } | ||
| }) | ||
| .catch(() => callback(`Failed to decrypt response for ${httpMethod} request`, res, res)); |
There was a problem hiding this comment.
why are we passing res parameter 2 times?
There was a problem hiding this comment.
For convension in callback we use 1st parameter for error, 2nd parameter for response body and 3rd parameter for entire response. As this part of code is inside processEncryptedResponse method res parameter is actually the response body, so in that case we could pass 3rd parameter as undefined, but I suppose that in that case we can pass response body(res) as the 3rd response parameter
vkorotchenko
approved these changes
Jan 11, 2019
wmews-hw
reviewed
Jan 16, 2019
wmews-hw
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.