DTPAYETWO-761- Added 'isDefaultTransferMethod' attribute for default accounts #124
Conversation
| * Set the is default transfer method | ||
| * | ||
| * @param string $isDefaultTransferMethod | ||
| * @return PayPalAccount |
There was a problem hiding this comment.
@return BankAccount will be more appropriate. Please check and update
src/Hyperwallet/Model/BankCard.php
Outdated
| * Set the is default transfer method | ||
| * | ||
| * @param string $isDefaultTransferMethod | ||
| * @return PayPalAccount |
There was a problem hiding this comment.
@return BankCard will be more appropriate. Please check and update
| * Set the is default transfer method | ||
| * | ||
| * @param string $isDefaultTransferMethod | ||
| * @return PayPalAccount |
There was a problem hiding this comment.
@return PrepaidCard will be more appropriate. Please check and update
| * Set the is default transfer method | ||
| * | ||
| * @param string $isDefaultTransferMethod | ||
| * @return PayPalAccount |
There was a problem hiding this comment.
@return TransferMethod will be more appropriate. Please check and update
There was a problem hiding this comment.
Updated, Thanks for pointing that out.
| @@ -63,6 +63,7 @@ | |||
| * @property string $stateProvince The state or province | |||
| * @property string $country The country | |||
| * @property string $postalCode The postal code | |||
| * @property string $isDefaultTransferMethod The is default transfer method | |||
There was a problem hiding this comment.
Suggestion: The field isDefaultTransferMethod can be explained better for the developers to understand. (Same for all model classes)
There was a problem hiding this comment.
There were some existing models which were using this property "isDefaultTransferMethod" and just to make it consistent across models, reused the same description. I've now updated the description for all of the models which were using this property
…rom string to bool
delete-merged-branch
bot
deleted the
feature/DTPAYETWO-761_defaultTransferPhpDev
branch
Design: https://engineering.paypalcorp.com/confluence/display/Payouts/Default+Transfer+Method+in+EA+responses
The change is to refine all of the external accounts API responses (GET, GET ALL) to include a "isDefaultTransferMethod" attribute holding a boolean value and is displayed only when the attribute is true which helps in determining the default account to which payment is made.