Feature/hw 58098 php sdk transfer refunds #41
Conversation
… tests with and without IT
src/Hyperwallet/Hyperwallet.php
Outdated
| return new Transfer($body); | ||
| } | ||
|
|
||
| public function createTransferRefund($transferToken, TransferRefund $transferRefund = null) { |
There was a problem hiding this comment.
TransferRefund $transferRefund = null can be just TransferRefund $transferRefund
There was a problem hiding this comment.
This is to accept null $transferRefund value. However when null value is passed, proper user friendly error message is returned. Removing 'null' value fails the test.
There was a problem hiding this comment.
I still feel that = null should be removed.
src/Hyperwallet/Hyperwallet.php
Outdated
| return new Transfer($body); | ||
| } | ||
|
|
||
| public function getTransferRefund($transferToken,$refundToken) { |
There was a problem hiding this comment.
($transferToken,$refundToken). Pls give a space here.
src/Hyperwallet/Hyperwallet.php
Outdated
| } | ||
| $body = $this->client->doGet('/rest/v3/transfers/{transfer-token}/refunds/{refund-token}', array( | ||
| 'transfer-token' => $transferToken, | ||
| 'refund-token'=>$refundToken), |
src/Hyperwallet/Hyperwallet.php
Outdated
| }); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Delete extra lines here.
There was a problem hiding this comment.
Revert the changes here. Pls revert all the formatting changes done in this whole file.
There was a problem hiding this comment.
clientRefundId is a string. Pls change it.
There was a problem hiding this comment.
Delete this extra line.
There was a problem hiding this comment.
Delete this extra line.
| } catch (HyperwalletArgumentException $e) { | ||
| $this->assertEquals('clientRefundId is required!', $e->getMessage()); | ||
| } | ||
|
|
| } | ||
| } | ||
|
|
||
|
|
| } | ||
| } | ||
|
|
||
| //****** |
There was a problem hiding this comment.
commented line above can be removed
| $this->assertEquals($foreignExchange1['destinationCurrency'], "CAD"); | ||
| $this->assertEquals($foreignExchange1['rate'], "2.3"); | ||
|
|
||
|
|
| array('transfer-token' => $transferToken), $transferRefund, array()); | ||
| } | ||
|
|
||
|
|
| $uriParams, $queryParams); | ||
| } | ||
|
|
||
|
|
| $uriParams, $queryParams); | ||
| } | ||
|
|
||
|
|
| } | ||
| } | ||
|
|
||
|
|
| ); | ||
| var_dump('Transfer created', $transfer); | ||
|
|
||
|
|
This reverts commit 5c8e8cd. add back TransferRefund.php#
No description provided.