added StakeHolder-Upload-Multi-Part-Document #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rrathinasabapath
suggested changes
Oct 13, 2020
| $this->assertEquals('businessToken is required!', $e->getMessage()); | ||
| } | ||
| } | ||
| public function testuploadDocumentsForBusinessUser() { |
There was a problem hiding this comment.
Please indicate if this is for 'success scenario' or 'with all parameters'
arao6
reviewed
Oct 13, 2020
src/Hyperwallet/Hyperwallet.php
Outdated
| @@ -2079,5 +2080,104 @@ public function listVenmoAccountStatusTransitions($userToken, $venmoAccountToken | |||
| return new VenmoAccountStatusTransition($entry); | |||
| }); | |||
| } | |||
| /** | |||
| * Upload documents for user endpoint | |||
There was a problem hiding this comment.
Please change the name of the model to BusinessStakeholder
Also, please update the comment for Business Stakeholder
arao6
reviewed
Oct 13, 2020
Rrathinasabapath
suggested changes
Oct 14, 2020
src/Hyperwallet/Hyperwallet.php
Outdated
| if (empty($businessToken)) { | ||
| throw new HyperwalletArgumentException('businessToken is required!'); | ||
| } | ||
| $body = $this->client->putMultipartData('/rest/v4/users/{user-token}/business-stakeholders/{business-stakeholders}', array('user-token' => $userToken,'business-stakeholders' => $businessToken), $options); |
There was a problem hiding this comment.
{business-stakeholders} can be renamed.
arao6
approved these changes
Oct 14, 2020
Rrathinasabapath
approved these changes
Oct 14, 2020
vkorotchenko
approved these changes
Oct 14, 2020
ramahalingam
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i have added stakeholder upload multi part documents