Skip to content
This repository is currently being migrated. It's locked while the migration is in progress.

Feature/v4 user endpoint php update #51

Closed
wants to merge 7 commits into from
Closed

Feature/v4 user endpoint php update #51

wants to merge 7 commits into from

Conversation

Rrathinasabapath
Copy link
Contributor

Please review the changes and approve.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 97.839% when pulling 1ad97ff on feature/V4-User-endpoint-PHP-Update into 2c4b98e on V4.

arao6
arao6 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@arao6 arao6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since most of the changes are the same for Create User, would be better to use the same branch - for create, update and list user.

@Rrathinasabapath
Copy link
Contributor Author

Closing this as these changes along with 'List Users' changes will be added to 'Create User' changes

@Rrathinasabapath Rrathinasabapath deleted the feature/V4-User-endpoint-PHP-Update branch October 16, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramahalingam ramahalingam Awaiting requested review from ramahalingam

1 more reviewer

@arao6 arao6 arao6 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rrathinasabapath @coveralls @arao6