Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added list of transfer methods #52

Merged
merged 7 commits into from
Oct 21, 2020

Conversation

madhankumar3103
Copy link
Contributor

added list of transfer methods

Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Ready to be reviewed by Peter before merging.

@peter-joseph
Copy link

Merge conflict

Copy link
Contributor

@arao6 arao6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pull the latest code from V4

Copy link

@vkorotchenko vkorotchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. just one question

@@ -2398,4 +2396,27 @@ public function listBusinessStakeholders($userToken , $options) {
return new BusinessStakeholder($entry);
});
}

//--------------------------------------
// Business Stakeholders

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this moved here by mistake? seems like everything above is business stakeholders and below is transfer methods

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i changed the comments

@madhankumar3103 madhankumar3103 removed the request for review from peter-joseph October 21, 2020 17:44
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 98.842% when pulling 6d67371 on feature/HW-67136-V4-Transfer-Methods into b0f245c on V4.

@akalichety-hw akalichety-hw merged commit ab887b4 into V4 Oct 21, 2020
@arao6 arao6 deleted the feature/HW-67136-V4-Transfer-Methods branch February 1, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants