Skip to content

Conversation

skambar110
Copy link
Contributor

Removed 'links' attribute for V4 Balances.

Copy link
Contributor

@arao6 arao6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rectify the errors that are causing the build to fail.
Undefined property: Hyperwallet\Response\ListResponse::$links
Above error in the ListBalances test methods - 6 errors.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 98.843% when pulling 034b35f on feature/HW-66742-V4-Balances-PHP into b0f245c on V4.

Copy link
Contributor

@Rrathinasabapath Rrathinasabapath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes. Ready to be reviewed by Peter before merging.

@akalichety-hw akalichety-hw merged commit 3b0fe91 into V4 Oct 21, 2020
@arao6 arao6 deleted the feature/HW-66742-V4-Balances-PHP branch February 1, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants