This repository is currently being migrated. It's locked while the migration is in progress.
added get list transfer and transfer methods #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhankumar3103
requested review from
vkorotchenko,
Rrathinasabapath and
arao6
arao6
suggested changes
Nov 16, 2020
Rrathinasabapath
approved these changes
Nov 17, 2020
hyperwallet/tests/test_encryption.py
Outdated
| @@ -41,7 +41,7 @@ def test_should_fail_decryption_when_wrong_private_key_is_used(self): | |||
| with self.assertRaises(HyperwalletException) as exc: | |||
| encryption2.decrypt(encryptedMessage) | |||
|
|
|||
| self.assertTrue(str(exc.exception).startswith('No recipient matched the provided key["Failed: [ValueError(\'Decryption failed.\'')) | |||
There was a problem hiding this comment.
did the expected behavior of this case change? / are we not expecting to see the Failed value anymore?
There was a problem hiding this comment.
Actually this is for old test case ,i did not modifying any code for encryption but i am facing build error so i modifying this line the build got success.
vkorotchenko
approved these changes
Nov 17, 2020
arao6
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added get transfer and list transfer and list transfer methods