Skip to content

fix: prevent crashing on invalid error reponse #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

fix: prevent crashing on invalid error reponse #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions src/hyperapp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,9 +267,16 @@ where
return Ok(r);
}

let e = serde_json::from_slice::<SendError>(&response_bytes)
.expect("Failed to deserialize response to send()");
return Err(AppSendError::SendError(e));
match serde_json::from_slice::<SendError>(&response_bytes) {
Ok(e) => Err(AppSendError::SendError(e)),
Err(err) => {
error!(
"Failed to deserialize response in send(): {} (payload: {:?})",
err, response_bytes
);
Err(AppSendError::BuildError(BuildError::NoBody))
}
}
}

pub async fn send_rmp<R>(request: Request) -> Result<R, AppSendError>
Expand All @@ -292,9 +299,16 @@ where
return Ok(r);
}

let e = rmp_serde::from_slice::<SendError>(&response_bytes)
.expect("Failed to deserialize response to send()");
return Err(AppSendError::SendError(e));
match rmp_serde::from_slice::<SendError>(&response_bytes) {
Ok(e) => Err(AppSendError::SendError(e)),
Err(err) => {
error!(
"Failed to deserialize response in send_rmp(): {} (payload: {:?})",
err, response_bytes
);
Err(AppSendError::BuildError(BuildError::NoBody))
}
}
}

// Enum defining the state persistance behaviour
Expand Down