Skip to content

Conversation

acelaya
Copy link
Collaborator

@acelaya acelaya commented Jun 6, 2025

Part of hypothesis/h#9548

Initialize the library with components to compose annotation-related cards and UIs, that will be used for hypothesis/client#7140 and hypothesis/h#9618.

Tip

The code inside src has been extracted from hypothesis/client#7140 verbatim.

The rest of the configuration files are based on the approach we usually follow in other similar projects, with one exception:

A stylesheet which imports tailwind styles used only for the tests. When more documentation is added we can extract that stylesheet to be reused there, as we do in frontend-shared.

This PR does not include a documentation or a sandbox for local development like we have in https://github.com/hypothesis/frontend-shared. That will be added in a follow-up PR.

Todo

  • Investigate one failing test
  • Add GitHub actions configuration
  • Add Makefile

@acelaya acelaya marked this pull request as ready for review June 9, 2025 09:55
@acelaya acelaya requested a review from robertknight June 9, 2025 09:56
Copy link
Contributor

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few project name references that need updating. Otherwise this looks good. I didn't review the changes under src/ since those are copied from the client repository.

@acelaya acelaya merged commit 85d2cdb into main Jun 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants