Fix typo in StyledText export #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When migrating h to Tailwind v4 I discovered that this export was broken. It hasn't caused a problem until now because in h the StyledText.css file is currently imported directly from lib/StyledText.css by SASS. That will change as part of the TWv4 migration.
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 9, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 9, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 9, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 9, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
robertknight
added a commit
to hypothesis/h
that referenced
this pull request
Sep 10, 2025
- Update Tailwind dependencies - Convert forms.scss to a "plain" CSS file. This avoids the SASS compiler trying to preprocess the Tailwind imports. - Update @hypothesis/annotation-ui for hypothesis/annotation-ui#87 - Update @hypothesis/frontend-build for Tailwind v4 support - Update @hypothesis/frontend-shared for hypothesis/frontend-shared#2083
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 15, 2025
The package update is needed for hypothesis/annotation-ui#87. See https://hypothes-is.slack.com/archives/C4K6M7P5E/p1757949882949179
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 15, 2025
The package update is needed for hypothesis/annotation-ui#87. See https://hypothes-is.slack.com/archives/C4K6M7P5E/p1757949882949179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating h to Tailwind v4 I discovered that this export was broken. It hasn't caused a problem until now because in h the StyledText.css file is currently imported directly from lib/StyledText.css by SASS. That will change as part of the TWv4 migration.