Repository navigation
Region screenshare creates repeated sessions at fractional scale #16955
Unanswered
CedrickMakhlouf
asked this question in
Bugs - Other
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Hyprland version
0.56.2
Is this a regression?
Yes. This started with the managed-session cache added in PR #11709, before v0.54.0. I don’t know how region sharing behaved before that change tho.
What's the bug?
When a region screenshare is active on a monitor with fractional scale (for
example, 1.25), Hyprland may create a new managed session on every frame.
The capture client supplies the region box in logical coordinates, but
session initialization scales and rounds it to physical pixels. The cache
then compares a new logical-coordinate box against the stored
physical-coordinate box, misses the match, and retains another session
while the stream is active.
Reproduction steps
over time.
Attachments
I’m currently using this local fix in
src/managers/screenshare/ScreenshareManager.cpp. It normalizes a copy of the incoming region box for the cache comparison; session creation still uses the original box.I acknowledge that:
I have searched all (open and closed) discussions and issues and my problem is not there.
I have read the Code of Conduct and agree to follow it.
I wrote this request with my own hands, my own keyboard, and in my own words.
All reactions