Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to ESLint 5 #186

Merged
merged 9 commits into from
Nov 9, 2018
Merged

Upgrade to ESLint 5 #186

merged 9 commits into from
Nov 9, 2018

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Nov 7, 2018

Purpose

Upgrade linter to support React 16 new features.

Changes

  • [Build] Upgrade to eslint@5.8.0.
  • [Build] Upgrade to eslint-config-ichef@2.0.0.
  • [Build] Upgrade to eslint-config-airbnb@17.1.0.

@zhusee2 zhusee2 added this to the Version 2 milestone Nov 7, 2018
@zhusee2 zhusee2 self-assigned this Nov 7, 2018
@zhusee2 zhusee2 requested a review from hsunpei November 7, 2018 04:29
@cjies cjies mentioned this pull request Nov 7, 2018
Closed
8 tasks
@zhusee2 zhusee2 mentioned this pull request Nov 8, 2018
Merged
hsunpei
hsunpei approved these changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@hsunpei hsunpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🚢

@zhusee2 zhusee2 merged commit 7c1cddf into develop Nov 9, 2018
@zhusee2 zhusee2 deleted the feature/upgrade_eslint branch November 9, 2018 02:48
@zhusee2 zhusee2 mentioned this pull request Nov 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsunpei hsunpei hsunpei approved these changes

Assignees

@zhusee2 zhusee2

Labels
enhancement
Projects
None yet
Milestone
2.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@zhusee2 @hsunpei