Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React 16.6 and Storybook v4 #187

Merged
merged 8 commits into from
Nov 12, 2018
Merged

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Nov 8, 2018

Purpose

Upgrade to React 16.6 so we can adapt new features in the future.

Changes

  • Breaking: raise component packages peer dependency to react@^16.6.0 and react-dom@^16.6.0
  • [Build] Upgrade to react@16.6.1 and prop-types@15.6.2.
  • [Storybook] Upgrade to @storybook/react@^4.0.0 to support Babel 7.

Dependency

@zhusee2 zhusee2 self-assigned this Nov 8, 2018
@zhusee2 zhusee2 requested a review from hsunpei November 8, 2018 07:47
@cjies cjies mentioned this pull request Nov 8, 2018
8 tasks
@zhusee2 zhusee2 changed the base branch from feature/upgrade_eslint to develop November 9, 2018 02:48
Copy link
Contributor

@hsunpei hsunpei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🥇

@zhusee2 zhusee2 merged commit 05044a3 into develop Nov 12, 2018
@zhusee2 zhusee2 deleted the feature/upgrade_react branch November 12, 2018 07:05
@zhusee2 zhusee2 mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants