-
Notifications
You must be signed in to change notification settings - Fork 14
Feature deploy on testnets with CreateX #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…new chain support
…polia configurations
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #216 +/- ##
========================================
Coverage 84.50% 84.50%
========================================
Files 35 35
Lines 1084 1084
Branches 221 221
========================================
Hits 916 916
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scripts/tools/copy-deployments.js
Outdated
const fs = require('fs-extra'); | ||
const path = require('path'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you use import
here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Zied Guesmi <26070035+zguesmi@users.noreply.github.com>
hardhat.config.ts
Outdated
@@ -1,4 +1,5 @@ | |||
import '@nomicfoundation/hardhat-toolbox'; | |||
import * as dotenv from 'dotenv'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import * as dotenv from 'dotenv'; | |
import 'dotenv/config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardhat.config.ts
Outdated
@@ -10,6 +11,7 @@ import { | |||
} from 'hardhat/internal/core/config/default-config'; | |||
import 'solidity-docgen'; | |||
import chainConfig from './utils/config'; | |||
dotenv.config(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dotenv.config(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…saveToDeployments in hardhat-fixture-deployer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good here, thanks!
No description provided.