Skip to content

Conversation

Le-Caignec
Copy link
Contributor

@Le-Caignec Le-Caignec commented Jul 24, 2025

Migration steps:

  • Migrate src files (minimal changes)
  • Modify receive and fallback behavior in Diamond.sol
  • Rename all 1538 to 2535 in contracts and rename Module to Facet in contracts names
  • Update all facets to use namespaces app storage.
  • Remove ENSIntegration modules/functions
  • Update docs (soldoc, diagrams, ...)
  • Add unit tests for Diamond.sol

@Le-Caignec Le-Caignec self-assigned this Jul 24, 2025
@Le-Caignec Le-Caignec changed the title chore: Remove ENS deployment and related files from the project feat: Remove ENS modules and related files from the project Jul 24, 2025
@Le-Caignec Le-Caignec changed the title feat: Remove ENS modules and related files from the project feat: Remove ENS modules and related files/dep from the project Jul 24, 2025
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (f82d8cf) to head (2ae042a).
Report is 1 commits behind head on feature/diamond.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/diamond     #225      +/-   ##
===================================================
- Coverage            84.44%   84.31%   -0.13%     
===================================================
  Files                   37       36       -1     
  Lines                 1112     1103       -9     
  Branches               225      223       -2     
===================================================
- Hits                   939      930       -9     
  Misses                 173      173              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@zguesmi zguesmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:Well done!

@Le-Caignec Le-Caignec merged commit 1da7dd1 into feature/diamond Jul 25, 2025
4 checks passed
@Le-Caignec Le-Caignec deleted the feature/remove-ens-support branch July 25, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants