-
Notifications
You must be signed in to change notification settings - Fork 14
feat: replace erc1538 naming to diamond proxy naming - part 2 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR continues the migration from ERC1538 naming to Diamond proxy pattern naming, specifically renaming all "Delegate" contract references to "Facet". This is part 2 of a larger refactoring effort to align the codebase with Diamond proxy architecture terminology.
- Replace all occurrences of "Delegate" with "Facet" in contract names, imports, and references
- Update import paths from
modules/delegates/
tomodules/facets/
- Maintain functional equivalence while improving architectural consistency
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/utils/IexecWrapper.ts | Update import and factory references from Delegate to Facet naming |
test/byContract/IexecPocoBoost/IexecPocoBoost.test.ts | Replace Delegate contract references with Facet equivalents |
test/000_fullchain-boost.test.ts | Update test descriptions and factory imports to use Facet naming |
scripts/tools/storage-to-diagrams.mjs | Update contract name for diagram generation |
scripts/tools/sol-to-uml.mjs | Replace Delegate contract names with Facet equivalents in UML generation |
scripts/sponsoring/1_add-modules-to-proxy.ts | Update deployment references and factory imports |
scripts/sponsoring/0_deploy-modules.ts | Replace module deployment configurations with Facet naming |
scripts/set-callback-gas.ts | Update factory import from Delegate to Facet |
scripts/boost/1_add-modules-to-proxy.ts | Update boost module deployment references |
scripts/boost/0_deploy-modules.ts | Replace boost module factories with Facet equivalents |
hardhat.config.ts | Update documentation exclusion paths from delegates to facets |
deploy/0_deploy.ts | Replace all factory instances and update Diamond import path |
contracts/tools/testing/slither/*.sol | Update contract imports and inheritance to use Facet naming |
contracts/tools/testing/IexecPocoBoostCompositeFacet.sol | New file replacing Delegate equivalent |
contracts/tools/testing/IexecPocoBoostCompositeDelegate.sol | Rename contract class to Facet while keeping filename |
contracts/tools/testing/IexecEscrowTestContract.sol | Update import path and comment references |
contracts/modules/facets/*.sol | Mass renaming of contract files and classes from Delegate to Facet |
contracts/modules/delegates/*.sol | Remove old Delegate contract files |
contracts/modules/FacetBase*.sol | Rename base contracts and update documentation |
contracts/Store.v8.sol | Update comment references from Delegate to Facet |
CHANGELOG.md | Add entry for the naming migration |
.solcover.js | Update exclusion path from delegates to facets |
Comments suppressed due to low confidence (1)
function broadcastWorkerpoolOrder(IexecLibOrders_v5.WorkerpoolOrder calldata _workerpoolorder) external override { emit BroadcastWorkerpoolOrder(_workerpoolorder); } | ||
function broadcastRequestOrder (IexecLibOrders_v5.RequestOrder calldata _requestorder ) external override { emit BroadcastRequestOrder (_requestorder ); } | ||
contract IexecRelayFacet is IexecRelay, FacetBase { | ||
function broadcastAppOrder(IexecLibOrders_v5.AppOrder calldata _apporder) external override { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The formatting of this contract declaration and subsequent method implementations should be consistent. The original compact formatting has been expanded, but some methods like 'broadcastAppOrder' maintain single-line format while others are multi-line, creating inconsistency.
function broadcastAppOrder(IexecLibOrders_v5.AppOrder calldata _apporder) external override { | |
function broadcastAppOrder( | |
IexecLibOrders_v5.AppOrder calldata _apporder | |
) external override { |
Copilot uses AI. Check for mistakes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #230 +/- ##
===================================================
- Coverage 83.85% 82.90% -0.96%
===================================================
Files 36 36
Lines 1109 1123 +14
Branches 225 225
===================================================
+ Hits 930 931 +1
- Misses 179 192 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Split de la PR #226 : #226 en 3