-
Notifications
You must be signed in to change notification settings - Fork 14
feat: refactor upgrade-helper to use DiamondCut for module updates #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the upgrade-helper to migrate from ERC1538 to DiamondCut standard for module updates. The changes replace ERC1538Query and ERC1538Update interfaces with DiamondCutFacet and DiamondLoupeFacet interfaces to align with the Diamond standard.
- Replace ERC1538 interfaces with Diamond standard interfaces
- Update module proxy update encoding to use diamondCut function with FacetCut structure
- Refactor function listing to use DiamondLoupe facets interface
FYI, the CI did not run because we have this: on:
push:
branches:
- feature/*
- bugfix/*
- develop
- release/*
- hotfix/*
- main
- v5 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/diamond #235 +/- ##
================================================
Coverage 83.66% 83.66%
================================================
Files 38 38
Lines 1218 1218
Branches 227 227
================================================
Hits 1019 1019
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…in upgrade-helper
…ate IexecLibOrders_v5
No description provided.