Skip to content

Conversation

Le-Caignec
Copy link
Contributor

No description provided.

@Le-Caignec Le-Caignec self-assigned this Jul 25, 2025
@Le-Caignec Le-Caignec requested review from gfournieriExec, zguesmi and Copilot and removed request for gfournieriExec, zguesmi and Copilot July 25, 2025 18:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the upgrade-helper to migrate from ERC1538 to DiamondCut standard for module updates. The changes replace ERC1538Query and ERC1538Update interfaces with DiamondCutFacet and DiamondLoupeFacet interfaces to align with the Diamond standard.

  • Replace ERC1538 interfaces with Diamond standard interfaces
  • Update module proxy update encoding to use diamondCut function with FacetCut structure
  • Refactor function listing to use DiamondLoupe facets interface

@zguesmi
Copy link
Member

zguesmi commented Jul 25, 2025

FYI, the CI did not run because we have this:

on:
  push:
    branches:
      - feature/*
      - bugfix/*
      - develop
      - release/*
      - hotfix/*
      - main
      - v5

Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.66%. Comparing base (3b43823) to head (7c758c9).
⚠️ Report is 6 commits behind head on feature/diamond.

Additional details and impacted files
@@               Coverage Diff                @@
##           feature/diamond     #235   +/-   ##
================================================
  Coverage            83.66%   83.66%           
================================================
  Files                   38       38           
  Lines                 1218     1218           
  Branches               227      227           
================================================
  Hits                  1019     1019           
  Misses                 199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zguesmi zguesmi merged commit b4963d2 into feature/diamond Jul 28, 2025
4 checks passed
@zguesmi zguesmi deleted the fix/fix-uprade-helper-script branch July 28, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants