feat: use storage lib #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed storage handling and access patterns across facets
…tBase and adjust LibPocoStorage access in related facets
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the codebase to use a centralized storage library pattern by converting the Store abstract contract to a LibPocoStorage library. This modernizes the storage access pattern using libraries instead of inheritance.
- Converts
Storeabstract contract toLibPocoStoragelibrary - Updates all storage access calls to use the new library pattern
- Removes unused ethers imports from test files
- Fixes minor syntax issues with modifier parentheses
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
contracts/libs/LibPocoStorage.v8.sol |
Converts abstract contract to library, fixes import path |
contracts/libs/LibPocoStorage.sol |
Converts abstract contract to library, updates import paths |
contracts/facets/*.sol |
Updates storage access to use library pattern instead of inheritance |
contracts/registries/*.sol |
Removes unnecessary parentheses from modifier calls |
test/*.ts |
Removes unused ethers imports |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #243 +/- ##
========================================
Coverage 83.66% 83.66%
========================================
Files 38 38
Lines 1218 1218
Branches 227 227
========================================
Hits 1019 1019
Misses 199 199 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zguesmi
approved these changes
Jul 28, 2025
contracts/libs/LibPocoStorage.sol
Outdated
| ****************************************************************************/ | ||
|
|
||
| abstract contract Store { | ||
| library LibPocoStorage { |
There was a problem hiding this comment.
Suggested change
| library LibPocoStorage { | |
| library PocoStorageLib { |
contracts/libs/LibPocoStorage.v8.sol
Outdated
| ****************************************************************************/ | ||
|
|
||
| abstract contract Store { | ||
| library LibPocoStorage { |
There was a problem hiding this comment.
Suggested change
| library LibPocoStorage { | |
| library PocoStorageLib { |
There was a problem hiding this comment.
This was referenced Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.