feat: set constant from public to internal

[gfournieriExec]

Found constants facet 0x56CDC32332648b1220a89172191798852706EB35 - will remove 8 specific constant functions
Found old accessor facet 0xEa232be31ab0112916505Aeb7A2a94b5571DCc6b with 32 functions - will remove ALL
Found old accessor facet 0xeb40697b275413241d9b31dE568C98B3EA12FFF0 with 1 functions - will remove ALL

DiamondProxy supports 102 functions:
Removal cuts: 3
  Cut 1: Remove 8 functions
  Cut 2: Remove 32 functions
  Cut 3: Remove 1 functions
Old functions removed successfully
Transaction hash: 0xec28206cb439542a0aea52388da80c3b76ce5e901cf5a42056ef3d82ae63b46a
Functions after upgrade:
DiamondProxy supports 94 functions:

All functions selector of IexecPocoAccessorsFacet__factory =>  [
  '0xdd62ed3e', '0x45b637a9', '0x70a08231',
  '0xe63ec07d', '0x66517ca6', '0x74ed5244',
  '0xc140996f', '0xb1b11d2c', '0x313ce567',
  '0x9910fd72', '0xdb8aaa26', '0x1bf6e00d',
  '0x25eacba8', '0xa47e7f80', '0x77a99692',
  '0xdcb03241', '0x06fdde03', '0x8da5cb5b',
  '0xd09cc57e', '0x2b8857c1', '0x95d89b41',
  '0x5975b8fc', '0xfc0c546a', '0x18160ddd',
  '0x6b55f4a5', '0x4f5f44ec', '0x4b2bec8c',
  '0xe741363b', '0xb74861b2', '0xd286eb16',
  '0xdb230b52', '0xadccf0d5', '0x6112f6fd',
  '0x90a0f546'
]
All functions selector of IexecAccessorsABILegacyFacet =>  [
  '0x8da5cb5b',
  '0x5b3ae3e4',
  '0xf9353b8d',
  '0xd5922f50',
  '0x11e35aba',
  '0xbd19a4f3',
  '0xce5f7895',
  '0x248ad6a0'
]
constantFunctionsToRemove => [
  '0x7b244832',
  '0x90fc26b1',
  '0x68a9ef1c',
  '0x9e986e81',
  '0xe2e7a8c1',
  '0x51152de1',
  '0x5fde601d',
  '0x4ec3b9e3'
]

[Copilot]

Pull Request Overview

Changes the visibility of protocol constants from public to internal in the facet base contracts and removes the corresponding public accessor functions from the legacy accessor facet.

• Updated constant visibility from public to internal in FacetBase contracts
• Removed the entire IexecAccessorsFacet.sol file containing public constant accessor functions
• Added deployment script logic to remove specific constant functions from the legacy constants facet

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
scripts/upgrades/accessors/deploy-and-update-accessor-facet.ts	Adds logic to remove specific constant getter functions from the legacy constants facet during upgrade
contracts/facets/IexecAccessorsFacet.sol	Completely removes the legacy accessor facet file
contracts/facets/FacetBase.v8.sol	Changes constant visibility from public to internal
contracts/facets/FacetBase.sol	Changes constant visibility from public to internal

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (f7c634b) to head (7fb43fd).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   83.66%   84.44%   +0.78%     
==========================================
  Files          38       37       -1     
  Lines        1218     1209       -9     
  Branches      227      227              
==========================================
+ Hits         1019     1021       +2     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Le-Caignec]

Good job thank you