-
Notifications
You must be signed in to change notification settings - Fork 1
feat: multichain support with wallet management #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
951cdb6
to
5ce11e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds multichain wallet management support to the iApp CLI, enabling operations on non-gasless chains like Arbitrum. The implementation includes encrypted wallet storage, transaction confirmation prompts, and balance checking to improve user experience and security.
- Replaces private key-based wallet handling with a comprehensive wallet management system
- Adds support for experimental networks (starting with Arbitrum Sepolia testnet) behind a feature flag
- Implements balance verification and transaction fee warnings for non-gasless chains
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
cli/src/utils/keystore.ts | New wallet storage utility with encryption/decryption functionality |
cli/src/cli-helpers/askForWallet.ts | Replaces private key prompts with wallet management interface |
cli/src/cmd/wallet-*.ts | New wallet import/select commands for wallet management |
cli/src/cmd/deploy.ts | Updated to use new wallet system and balance checking |
cli/src/cmd/run.ts | Updated to use new wallet system with transaction confirmations |
cli/src/utils/iexec.ts | Modified to accept signers instead of private keys |
cli/src/config/config.ts | Added experimental network configuration |
Files not reviewed (1)
- cli/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
cli/src/utils/keystore.ts:48
- Typo in warning message: 'de replaced' should be 'be replaced'
}
3cd845a
to
f52e509
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
f52e509
to
6023710
Compare
Why continue generating a random wallet during project initialization, even if the wallet will be empty and unusable on Arbitrum? |
Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
We want the process to be as easy as possible on bellecour, which will be the only free sandbox environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wallet management for non-gasless chains
full spec https://iexecproject.atlassian.net/wiki/spaces/IP/pages/3903684674/E+Support+Arbitrum+in+iApp+Generator
features
iapp wallet import
iapp wallet select
iapp deploy
andiapp run
)iapp deploy
andiapp run
)EXPERIMENTAL_NETWORKS
feature flagabitrum-sepolia-testnet
added as experimental networkmisc