Skip to content

Conversation

PierreJeanjacquot
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot commented Aug 19, 2025

This PR switches the communication protocol to the previously experimental websocket API

Copy link

github-actions bot commented Aug 19, 2025

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
api/Dockerfile:4 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

@PierreJeanjacquot PierreJeanjacquot changed the title feat: use websocket for client server communication feat: use websocket for client server communication (previously enabled by EXPERIMENTAL_WS_API) Aug 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR switches from the experimental websocket API (previously enabled by EXPERIMENTAL_WS_API flag) to making it the default communication protocol, removing the HTTP-based fallback entirely. The change simplifies the client-server communication by using websockets exclusively.

Key changes:

  • Removed the EXPERIMENTAL_WS_API feature flag and websocket conditional logic
  • Deprecated HTTP endpoints and handlers in favor of websocket communication
  • Added deprecation warnings for old features including HTTP endpoints, legacy templates, and scone versions

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cli/src/utils/sconify.ts Removed HTTP fallback logic, now uses websockets exclusively
cli/src/utils/featureFlags.ts Removed useWsApi feature flag
cli/src/config/config.ts Removed HTTP API URL constant
api/src/sconify/sconifyBuild.handler.ts Renamed HTTP handler to deprecated, added deprecation warnings
api/src/sconify/deprecated_sconify.handler.ts Added deprecation warnings to legacy handlers
api/src/index.ts Updated to use deprecated HTTP handler
api/src/constants/constants.ts Updated comments to mark legacy features as deprecated
api/README.md Updated documentation to reflect websocket-first API design

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@PierreJeanjacquot PierreJeanjacquot self-assigned this Aug 19, 2025
Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
@PierreJeanjacquot PierreJeanjacquot merged commit 1a3bb23 into main Aug 20, 2025
6 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the feat/ws-stable branch August 20, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants