Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return unknown if position is over 100 #172

Merged
merged 7 commits into from
Jul 28, 2020
Merged

Return unknown if position is over 100 #172

merged 7 commits into from
Jul 28, 2020

Conversation

iMicknl
Copy link
Owner

@iMicknl iMicknl commented Jul 24, 2020

Fix #44

@github-actions github-actions bot added the enhancement New feature or request label Jul 24, 2020
This was referenced Jul 24, 2020
Closed
Closed
@tetienne
Copy link
Collaborator

I don't see the link with the issue.

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 24, 2020

@tetienne sorry, the context was in a PR linked to that issue. #48 (comment)

@tetienne
Copy link
Collaborator

@tetienne sorry, the context was in a PR linked to that issue. #48 (comment)

Oh that's why there was an offset in the previous code?

@iMicknl
Copy link
Owner Author

iMicknl commented Jul 27, 2020

@tetienne sorry, the context was in a PR linked to that issue. #48 (comment)

Oh that's why there was an offset in the previous code?

Nope, that offset is not related to this issue. That was even older legacy code. :)

@iMicknl iMicknl added bug Something isn't working and removed enhancement New feature or request labels Jul 27, 2020
@iMicknl
Refactor feedback
9a41b8e
@iMicknl
Squashed commit of the following:
fb16f84 
commit c7ca453
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Mon Jul 27 16:32:04 2020 +0200

    Add device attributes to attributes (#180)

commit 0883cf6
Author: tetienne <thibaut@etienne.pw>
Date:   Mon Jul 27 14:14:38 2020 +0200

    Fix assumed state (#178)

commit b490d79
Author: tetienne <thibaut@etienne.pw>
Date:   Mon Jul 27 14:02:58 2020 +0200

    Fix execute_command call (#176)

commit 9560cfa
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sun Jul 26 13:01:16 2020 +0200

    Add more ui_classes and sort them alphabetically (#168)

commit b01f2ca
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sun Jul 26 12:53:15 2020 +0200

    Improve support for GasSensor, ThermalEnergySensor, WaterSensor and add support for Siren Status (#170)
@iMicknl
Add extra check..
e5b5246
@iMicknl
Fix position statement
f566655
@iMicknl iMicknl changed the base branch from master to add_basic_alarm_component July 27, 2020 20:50
@iMicknl iMicknl changed the base branch from add_basic_alarm_component to master July 27, 2020 20:50
vlebourl
vlebourl approved these changes Jul 28, 2020
View reviewed changes
Copy link
Collaborator

@vlebourl vlebourl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you it's the correct behaviour, I don't own the device...

@iMicknl iMicknl merged commit 489e72f into master Jul 28, 2020
@iMicknl iMicknl deleted the enhancement/fix_uno_devices branch July 28, 2020 12:38
@lindemar
Copy link

Meanwhile I was able to try out this fix based on #187 (#172 was already merged to master). In my case it works as expected. Thank you all for your effort fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tetienne tetienne tetienne approved these changes

@vlebourl vlebourl vlebourl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

State not updated for Awning (io:AwningReceiverUnoIOComponent)
4 participants
@iMicknl @tetienne @lindemar @vlebourl