NAV_LAUNCH: add min time before leaving #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalentity
requested changes
Jan 23, 2018
src/main/navigation/navigation.h
Outdated
| @@ -155,6 +155,7 @@ typedef struct navConfig_s { | |||
| uint16_t launch_throttle; // Launch throttle | |||
| uint16_t launch_motor_timer; // Time to wait before setting launch_throttle (ms) | |||
| uint16_t launch_motor_spinup_time; // Time to speed-up motors from idle to launch_throttle (ESC desync prevention) | |||
| uint16_t launch_min_time; // Minimum time in launch mode to prevent possible bump of the sticks from leaving launch mode early | |||
There was a problem hiding this comment.
Please fix the indentation
There was a problem hiding this comment.
Done. I need to change my auto-indentation settings for iNav.
digitalentity
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I'm launching my big wings I often do a over head launch using two hands. Before this patch I was laying my remote control down on the ground so that I could not accidentally bump the roll/pitch stick making the wing leave launch mode prematurely. This patch adds a delay after launch during which launch mode can't be interrupted by the roll/pitch stick. If the aircraft is going to crash or has crashed during the delay the user can still disarm or put the throttle to 0 to stop the motor(s).
This adds the new setting
nav_fw_launch_min_timerepresenting the described delay in milliseconds set by default to 0.