Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if AUTOTRIM is enabled before arming and avoid arming. #2756

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

giacomo892
Copy link
Collaborator

Avoiding to ARM with AUTOTRIM enabled will prevent the plane to trim on the ground while not leveled in pilot's hands with mayor effects on the flight performance.

Also while checking this I've noted that SERVO_AUTOTRIM_TIMER_MS is set to 1000 while on the documentation it says to fly level for 5 seconds.

Should we increase it at least to 2s to allow for better trimming if there is some turbulence?

@fiam fiam merged commit fd5938a into iNavFlight:development Feb 14, 2018
@giacomo892 giacomo892 deleted the autotrim_mods branch February 14, 2018 12:56
@shellixyz
Copy link
Collaborator

I think it is a good idea to increase the autotrim timer. 5 seconds doesn't seem too much. 1 second definitely seems too little. At least the documentation should be updated. I was surprised when I used it and it changed the controls in less than 5 seconds.

@giacomo892
Copy link
Collaborator Author

giacomo892 commented Feb 14, 2018

I'm doing a PR updating it to 2 seconds. With 1 second it is doing a rather good job. 5 perhaps is too long (#2769)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants