Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trip distance not shown without current sensor #3163

Merged
merged 1 commit into from May 6, 2018

Conversation

Projects
None yet
3 participants
@digitalentity
Copy link
Member

commented May 5, 2018

Fix for #3162

@digitalentity digitalentity added this to the 2.0 milestone May 5, 2018

@digitalentity digitalentity requested a review from fiam May 5, 2018

@fiam
Copy link
Member

left a comment

This is the correct fix, we want to skip OSD_EFFICIENCY_WH_PER_KM when no current sensor is present.

However, this function right now is a total mine field that needs to be tweaked every time we add a new OSD element. I need to profile the element iteration a bit, maybe we can get away with some simpler code.

@shellixyz

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2018

Yeah this function is really a pain to maintain

@digitalentity

This comment has been minimized.

Copy link
Member Author

commented May 6, 2018

Yes, we need something better that this function. While this is probably the most efficient approach, it's total black magic at first glance and a pain to maintain. I'm probably ok with some slower code that's easier to read.

@digitalentity

This comment has been minimized.

Copy link
Member Author

commented May 6, 2018

Merging this for the time being.

@digitalentity digitalentity merged commit 05a9be3 into development May 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@digitalentity digitalentity deleted the de_fix_trip_distance branch May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.