Fix trip distance not shown without current sensor #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiam
reviewed
May 5, 2018
There was a problem hiding this comment.
This is the correct fix, we want to skip OSD_EFFICIENCY_WH_PER_KM when no current sensor is present.
However, this function right now is a total mine field that needs to be tweaked every time we add a new OSD element. I need to profile the element iteration a bit, maybe we can get away with some simpler code.
|
Yeah this function is really a pain to maintain |
|
Yes, we need something better that this function. While this is probably the most efficient approach, it's total black magic at first glance and a pain to maintain. I'm probably ok with some slower code that's easier to read. |
|
Merging this for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3162