Add missing OSD alarm settings from CLI #3182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellixyz
force-pushed
the
add_missing_osd_alarm_settings
branch
from
72b26af
to
498aee9
Compare
fiam
reviewed
May 7, 2018
| @@ -158,7 +158,7 @@ static displayPort_t *osdDisplayPort; | |||
| #define AH_SIDEBAR_WIDTH_POS 7 | |||
| #define AH_SIDEBAR_HEIGHT_POS 3 | |||
|
|
|||
| PG_REGISTER_WITH_RESET_FN(osdConfig_t, osdConfig, PG_OSD_CONFIG, 1); | |||
| PG_REGISTER_WITH_RESET_FN(osdConfig_t, osdConfig, PG_OSD_CONFIG, 2); | |||
There was a problem hiding this comment.
No need to increase the version here, since you didn't touch osdConfig_t, just exposed its already existing fields. Doesn't matter because this is going to be split into 2 groups (elements and settings) before 2.0 and we'll need to increase the version anyway, so no harm in increasing it in this PR.
There was a problem hiding this comment.
Oops it was not for this branch
|
Good catch! We should add them in CMS too after this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.