Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FPort stop one sensor cycle every 3 #3308

Merged
merged 2 commits into from Jun 9, 2018

Conversation

Projects
None yet
2 participants
@fiam
Copy link
Member

commented Jun 1, 2018

Sending 3 cycles and then pausing once still produces some sensor
lost warnings after 10-15 mins, but reducing it to 2 sensors/1 pause
seems to get rid of the problem. Since this reduces the effective data
rate by 33%, changes have been removed from the SmartPort driver and
moved to affect just FPort. This way, S.Port doesn't have suffer any
update rate reductions.

Fixes #3198 (hopefully for real this time)

@fiam fiam added this to the 2.0 milestone Jun 2, 2018

fiam added some commits May 20, 2018

Make FPort stop one sensor cycle every 3
Sending 3 cycles and then pausing once still produces some sensor
lost warnings after 10-15 mins, but reducing it to 2 sensors/1 pause
seems to get rid of the problem. Since this reduces the effective data
rate by 33%, changes have been removed from the SmartPort driver and
moved to affect just FPort. This way, S.Port doesn't have suffer any
update rate reductions.

Fixes #3198 (hopefully for real this time)
Check for payload != NULL in smartPortPayloadContainsMSP()
When calling it from the fport driver, the payload might be NULL in
some cases, causing an invalid dereference.

Found by @jirif on betaflight/betaflight#6060

@fiam fiam force-pushed the agh_fport_rest_period_2 branch from 86d4437 to df5d50d Jun 8, 2018

@fiam fiam merged commit 609cdec into development Jun 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fiam fiam deleted the agh_fport_rest_period_2 branch Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.