Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string settings, make "name" a setting rather an a CLI command #3428

Merged
merged 2 commits into from Jun 25, 2018

Conversation

Projects
None yet
1 participant
@fiam
Copy link
Member

commented Jun 24, 2018

  • Rename settings related functions from snake_case to camelCase
  • Teach settings how to handle strings, make craft name a setting

fiam added some commits Jun 23, 2018

Rename settings related functions from snake_case to camelCase
Fits better with INAV code conventions

Renamed functions:
    - setting_get_name -> settingGetName
    - setting_name_contains -> settingNameContains
    - setting_name_exact_match -> settingNameIsExactMatch
    - setting_find -> settingFind
    - setting_get_value_size -> settingGetValueSize
    - setting_get_pgn -> settingGetPgn
    - setting_get_value_pointer -> settingGetValuePointer
    - setting_get_copy_value_pointer -> settingGetCopyValuePointer
    - setting_get_min -> settingGetMin
    - setting_get_max -> settingGetMax
Teach settings how to handle strings, make craft name a setting
Add a new type for settings to be able to handle strings. This makes
it easier to add more settings of this type and removes the need to
handle them with dedicated CLI commands.

Replace the `name` CLI command with a setting called `name`.

Saves 8 bytes of FLASH on OMNIBUS

@fiam fiam added this to the 2.0 milestone Jun 24, 2018

@fiam fiam merged commit d4d5e4a into development Jun 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fiam fiam deleted the agh_name_as_setting branch Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.