Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a CI to check the format of the code #82

Closed
amtoine opened this issue Mar 28, 2023 · 3 comments · Fixed by #83
Closed

add a CI to check the format of the code #82

amtoine opened this issue Mar 28, 2023 · 3 comments · Fixed by #83
Assignees
@atxr
Labels
enhancement New feature or request help wanted Extra attention is needed Priority: High The Issue must be addressed as soon as possible repo issue An issue that address the whole project/repo not a specific code feature

Comments

@amtoine
Copy link
Member

amtoine commented Mar 28, 2023 •
edited
Loading

cc/ @atxr

about the question in #78 and the change request in #81.

@atxr, could you add a very simple CI in .github/workflows/ to format check the format of the code base with prettier? 😋

EDIT: the CI should fail if the format is not good. the CI should not try to commit on top of a PR branch if the format is bad.
@amtoine amtoine added enhancement New feature or request help wanted Extra attention is needed repo issue An issue that address the whole project/repo not a specific code feature labels Mar 28, 2023
@ctmbl
Copy link
Contributor

ctmbl commented Mar 28, 2023

That would be sooooo cool

@amtoine
Copy link
Member Author

amtoine commented Mar 29, 2023

that's a must have 👍

@ctmbl ctmbl added the Priority: High The Issue must be addressed as soon as possible label Mar 30, 2023
atxr added a commit to atxr/iscsc.fr that referenced this issue Mar 30, 2023
@atxr
add a CI to format the code
730713f 
Fixes iScsc#82
@atxr atxr mentioned this issue Mar 30, 2023
Merged
atxr added a commit to atxr/iscsc.fr that referenced this issue Mar 30, 2023
@atxr
add a CI to format the code
63cdb64 
Fixes iScsc#82
@amtoine amtoine changed the title add a CI to format the code add a CI to chek the format of the code Mar 30, 2023
@amtoine
Copy link
Member Author

amtoine commented Mar 30, 2023

@atxr

i've updated the issue title and description 👍

sorry i was in a rush yesterday...
i was not clear 😋

@atxr atxr changed the title add a CI to chek the format of the code add a CI to check the format of the code Mar 31, 2023
atxr added a commit to atxr/iscsc.fr that referenced this issue Apr 2, 2023
@atxr
add a CI to format the code
c3e7978 
Fixes iScsc#82
@ctmbl ctmbl closed this as completed in #83 Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in iScsc website Apr 3, 2023
ctmbl pushed a commit that referenced this issue Apr 3, 2023
@atxr
add a CI to format the code (#83)
19d1706 
* add a CI to format the code

Fixes #82

* Fix typo in the folder name

* Check instead of write

* Switch to 4.3 to fix a bug

* Add prettier config to the project

* Add quotes

Without quotes, the path is not recursive (only of depth 1)

* Format files

* Rename action

* Remove quotes

* Remove dry run

* Test CI

* Revert last commit after successful test

* Fix issue with formatting when reverting test commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atxr atxr

Labels
enhancement New feature or request help wanted Extra attention is needed Priority: High The Issue must be addressed as soon as possible repo issue An issue that address the whole project/repo not a specific code feature
Projects
iScsc website
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add a CI to format the code atxr/iscsc.fr
3 participants
@atxr @amtoine @ctmbl