Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm install windows 10 #1529

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Fix npm install windows 10 #1529

merged 2 commits into from
Dec 2, 2020

Conversation

gchoqueux
Copy link
Contributor

Description

fix(install): prepare script spends a lot of time, to check npm version.

The issue is calling npm --version with nodejs child_process.execSync
The fix is set environment variable NO_UPDATE_NOTIFIER=true
With windows 10 behind proxy.

@gchoqueux gchoqueux added this to the 2.28.0 milestone Dec 2, 2020
@gchoqueux gchoqueux merged commit b5ff9e9 into iTowns:master Dec 2, 2020
@gchoqueux gchoqueux deleted the fix_npm branch December 2, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgermerie mgermerie mgermerie approved these changes

Assignees
No one assigned
Labels
release 🌈
Projects
None yet
Milestone
2.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gchoqueux @mgermerie