chore(deps): June 2024 bump #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the updates. Here are a few answers to the points you mention :
|
|
Thanks @mgermerie for your review!
Noted, I'll do it. Note that this does not impact downstream users (only developer of the itowns repo).
Shall I open an issue or shall we discuss this on our next dev meeting?
As you wish, I could fix them in this PR and not report the fixes in 2/3 years x) |
jailln
reviewed
Jul 4, 2024
Desplandis
force-pushed
the
bump/jun24
branch
2 times, most recently
from
ad667cf
to
8bb4777
Compare
|
Bump the following dependencies: - babel (cli, core, plugin-transform-runtime, preset-env) - c8 - chart.js - core-js - https-proxy-agent - jsdoc - puppeteer - replace-in-file - sinon - typescript - webpack (eslint-webpack-plugin, webpack-dev-server)
This release is now with ESM modules
@tweenjs/tween.js is now distributed as an ESM-only package
@mapbox/vector-tile is now distributed as an ESM only package
eartcut is now distributed as an ESM-only module
pbf is now distributed as an ESM-only module
mgermerie
approved these changes
Jul 24, 2024
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update all dependencies (when possible). A lot of dependencies now mandates node >= 18.0.0, shall we mark this as breaking changes?
Previous major bump in #2234
Peer dependencies
three(0.159.0to0.165.0): Removed WebGL1 (no issue for us).proj4(2.9.2to2.11.0): No breaking changesDependencies
Those are the packages with a new version available:
earcut: Distributes as ESM now.@mapbox/mapbox-gl-style-spec(13.28.0): Still the same problems as chore(deps): December 2023 bump #2234. Will not update due to the fact this is the latest version with a FOSS license (ISC). This is a huge red-flag, shall we consider moving to@maplibre/maplibre-gl-style-spec@iTowns/reviewers?@mapbox/vector-tile: Distributes as ESM now.pbf: Distributes as ESM now.shpjs(4.0.4to5.0.1): Distributes as ESM now. No issue since we already migrated to ESM.@tweenjs/tween.js(18.6.4to23.1.2): Distributes as ESM now. A few breaking changes which does not impact us.Developer dependencies
Those packages upgrades introduce no breaking change:
@babel/cli,@babel/coreand the following plug-ins:@babel/plugin-transform-runtimeand@babel/preset-env.c8.chart.js.conventional-changelog-cli: Pure ESM package, issues with our CJS script.core-js.eslintand the following plug-in:eslint-plugin-import: cannot update to ESLint 9 since the plugin requires ESLint8.https-proxy-agent.jsdoc.marked: unused, remove (added in fix(core): marked dependency is insecure version #612)mocha: update cause deprecation notice ofglobdependency.node-fetch: Can update to3.x.xsince we are now a ESM only package. TypeError with fetcher.js test. Note that node 18 support natively thefetchAPI.puppeteer.replace-in-file.sinon.typescript.webpackand the following plugin:webpack-dev-serverandeslint-webpack-plugin.