Increase SelectionCountField margins (backport #979)
#988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We had no padding on the right side of the
SelectionCountFieldand it looked weird when there was a separator after it (the separator removes padding between different status bar fields). Changes:--iui-size-xs) from both left and right sides now. I chose margins instead of paddings because padding is considered a part of the width so it basically decreased themin-widththat we set (more specifically it would decrease the space reserved for more digits).min-widthfrom--iui-size-2xl(equivalent to4rem) to3.75rem. This slightly decreases the min width of the component and is perfect to fit 5 digits without shifting other status bar content. I made this change because we previously hadpadding-leftwhich is now switched tomargin-left(again, the padding eats into the width and margin does not) so the freed up space was not needed anymore.Adding some screenshots for comparison. Note that the first two images have separators.
Before:
After:
Fixes #978.
Testing
Tested in test-app.
This is an automatic backport of pull request #979 done by [Mergify](https://mergify.com).