Render MenuItem without item or submenu
#989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GerardasB
approved these changes
Sep 3, 2024
|
@Mergifyio backport release/4.16.x |
✅ Backports have been created
|
GerardasB
added a commit
that referenced
this pull request
Sep 3, 2024
* Render `MenuItem` without `item` or `submenu` (#989) * Render MenuItem without item or submenu * Add test * Update changelog (cherry picked from commit 71f2d73) # Conflicts: # docs/changehistory/NextVersion.md * Remove NextVersion.md changes --------- Co-authored-by: Ignas Kasinskas <138560995+ignas-k@users.noreply.github.com> Co-authored-by: GerardasB <10091419+GerardasB@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #875 the
itemprop ofCursorMenuItemPropswas deprecated and replacement props added. However,MenuItemHelpers.createMenuItemNodewas still checking if theMenuItemhaditemorsubmenu. Using the new props this condition would fail and the function would return null instead of a component node.I changed the function to render
ContextMenuItemby default (without any condition) so this does change the behaviour slightly. Before if theactionItemorsubmenuwas not set it would return null but now it will return a normal node. I believe this is fine becauseMenuItemconstructor already has a check that at least one ofitem,submenuorexecuteprop has to be used or it throws an error. So technically it should not even be possible to passMenuItemwithout required properties to theMenuItemHelpers.createMenuItemNodefunction.Fixes #984.
Testing
Added a test and changed component examples to adjust for the deprecation.