-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Electron 11 to pick up Node fixes #436
Conversation
@pmconne @swwilson-bsi mind reviewing? |
@calebmshafer Before upgrading Node:
After upgrading to Node 14.15.4:
|
@pmconne yes, this doesn't yet support Node 14.x. That will be a separate PR. Fixing the tsutils issue now. I'll push an update in a minute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any regressions in display-test-app. OIDC sign-in still works.
The update to Electron 11 picks up a fix in Node (included in Node 12.18.3) for a crash during the destructor of ObjectWrap from napi.
The Electron update looks to have fixed the issue @ramanujam-raman ran into during the Electron 10 update. However, we need to do a bit more testing to make sure. That's still a work in progress.Update: This did not fix the issue with exiting the app on Windows in Certa. Reverting those changes. However, it still fixes the other issue so is worth updating.
tl;dr
While @wgoehrig and I were debugging into a MacOS hang in the CI builds, we discovered it is due to a crash in the core-full-stack-tests when running in Electron. After the initial crash, and the crash report pops up, a subsequent run of Electron opens a dialog that asks if you want to restart from the previous state. This dialog is silly for a CI build since you don't want to usually use the previous state, we're working on fixing that in the CI infrastructure to avoid it hanging for that reason ever again.
After we figured that out, we started to dig into the crash itself. From the callstack (let me know if you want the full callstack), we found it was due to the destructor of the ObjectWrap causing the issue,
The following trace of GitHub issues led us to find that this was an issue directly in Node and not napi. The fix has been back ported to both >=12.18.3 and 14.x. In order to pick this fix up in Electron, we have to update to Electron 11 which includes 12.18.3 as its Node version.
All of this said, we do have another crash in the native code from these tests which doesn't appear to be related. It happens less often than the current one. I'll follow up on that separately.