Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid color scheme not loading #689

Closed
SelbiEreshova opened this issue Aug 2, 2022 · 7 comments
Closed

Solid color scheme not loading #689

SelbiEreshova opened this issue Aug 2, 2022 · 7 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SelbiEreshova
Copy link
Collaborator

SelbiEreshova commented Aug 2, 2022

On unstable branch saving maps with solid color scheme and uploading them back to newt gives an error.

Try this:

  • Open first PD sample
  • Change color scheme to solid
  • Save the file
  • Load this file back to Newt
@hasanbalci hasanbalci removed their assignment Jan 18, 2023
@umut-er umut-er mentioned this issue Jun 4, 2024
2 tasks
@ugurdogrusoz
Copy link
Contributor

Might be related to #708 item 1.

@ugurdogrusoz ugurdogrusoz added the bug Something isn't working label Jun 4, 2024
@okg21
Copy link
Contributor

okg21 commented Jun 7, 2024

I believe this bug has been introduced with this commit for fixing e966655 #574.
Actions to remove background image related style properties have been added. And these fields are saved to the file with empty('') values. For the following properties:
['background-fit', 'background-image-opacity', 'background-position-x', 'background-position-y', 'background-height', 'background-width']

Having empty fields in the saved file results in NaN values when parsed. And cytoscape's style does not accept these NaN values.

Removing these actions fixes this bug, without the clone marker bug mentioned on the #574 reappearing and undo does not take two times. But I wonder if we do lose any utility in this case.

Another solution is checking for NaN values before applying node.style(). But this seems like a bad practice.

@ugurdogrusoz
Copy link
Contributor

Let's try reverting the incorrect parts of the mentioned commit. We'll test it thoroughly later.

@okg21
Copy link
Contributor

okg21 commented Jun 14, 2024

I committed a fix for the clone marker bug. Now color schemes are loading correctly. And clone marker bug for unspecified entity and perturbing agent is fixed.

@okg21 okg21 assigned ugurdogrusoz and unassigned okg21 Jun 14, 2024
@ugurdogrusoz
Copy link
Contributor

All samples are loading as solid right now. Most should be 3D or gradient.

@ugurdogrusoz
Copy link
Contributor

@okg21 When we load a sample, the color scheme is incorrect. Let's first fix that so we can see if this original issue is fixed.
The picture below is what we get when we load the first PD sample; what's wrong is red, whereas what is correct is in green:
Screenshot 2024-06-20 at 17 40 33

@okg21
Copy link
Contributor

okg21 commented Jun 26, 2024

With the latest rebuild color schemes are displayed correctly on unstable.
ScreenRecording2024-06-26at14 11 17-ezgif com-video-to-gif-converter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants