-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solid color scheme not loading #689
Comments
Might be related to #708 item 1. |
I believe this bug has been introduced with this commit for fixing e966655 #574. Having empty fields in the saved file results in NaN values when parsed. And cytoscape's style does not accept these NaN values. Removing these actions fixes this bug, without the clone marker bug mentioned on the #574 reappearing and undo does not take two times. But I wonder if we do lose any utility in this case. Another solution is checking for NaN values before applying node.style(). But this seems like a bad practice. |
Let's try reverting the incorrect parts of the mentioned commit. We'll test it thoroughly later. |
I committed a fix for the clone marker bug. Now color schemes are loading correctly. And clone marker bug for unspecified entity and perturbing agent is fixed. |
All samples are loading as solid right now. Most should be 3D or gradient. |
@okg21 When we load a sample, the color scheme is incorrect. Let's first fix that so we can see if this original issue is fixed. |
On unstable branch saving maps with solid color scheme and uploading them back to newt gives an error.
Try this:
The text was updated successfully, but these errors were encountered: