Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newt 4 issues #708

Closed
2 tasks done
NoorMuhammad1 opened this issue Jun 3, 2024 · 7 comments
Closed
2 tasks done

Newt 4 issues #708

NoorMuhammad1 opened this issue Jun 3, 2024 · 7 comments
Assignees
Milestone

Comments

@NoorMuhammad1
Copy link
Contributor

NoorMuhammad1 commented Jun 3, 2024

Upon my testing of the current unstable branch of newt, I have encountered the following issues:

  • 1. [@okg21] Color scheme not being properly loaded for sample maps.
  • 2. [@NoorMuhammad1] SBGN bricks not working for Association. Can also test for other types as well.

If anybody finds any other issues or bugs please add it here.

@ugurdogrusoz ugurdogrusoz changed the title Fixes needed for Newt 4 Newt 4 issues Jun 4, 2024
@umut-er
Copy link
Contributor

umut-er commented Jun 4, 2024

I have not been able to recreate the above-mentioned issues. Can you perhaps go into a little bit more into detail as to how to recreate them? Is the first issue related to #689? Does "SBGN bricks not working for Association" mean that it doesn't generate output at all or that there is something wrong with the output?
I have been testing for some time and haven't encountered any issues. I haven't looked at the query tab yet.

@NoorMuhammad1
Copy link
Contributor Author

NoorMuhammad1 commented Jun 4, 2024 via email

@umut-er
Copy link
Contributor

umut-er commented Jun 4, 2024

Same issue with:
metabolic reaction (input/output fields should include macromolecules)
dissociation (input/outputs field should include simple chemicals)
degradation (input/outputs field should include simple chemicals)

@ugurdogrusoz
Copy link
Contributor

ugurdogrusoz commented Jun 4, 2024

@amazein @adrienrougny can you please check this release candidate for Newt 4 in regards to our requirements for what input/outputs for above mentioned SGBN bricks should be (see under Edit > Add Using SBGN Bricks..)? We might have changed these when we extended the support for SBGN bricks.

Specs we had prepared earlier.

@NoorMuhammad1
Copy link
Contributor Author

I checked and the SBGN bricks modal works and is following all the specified rules.

@ugurdogrusoz ugurdogrusoz added this to the version 4.0 milestone Jun 5, 2024
@ugurdogrusoz
Copy link
Contributor

@amazein @adrienrougny can you please check this release candidate for Newt 4 in regards to our requirements for what input/outputs for above mentioned SGBN bricks should be (see under Edit > Add Using SBGN Bricks..)? We might have changed these when we extended the support for SBGN bricks.

Specs we had prepared earlier.

@NoorMuhammad1 checked and things looked fine according to this document

@okg21
Copy link
Contributor

okg21 commented Jun 26, 2024

With this PR on sbgnviz iVis-at-Bilkent/sbgnviz.js#219, the color scheme issue for samples is fixed.

@okg21 okg21 assigned ugurdogrusoz and unassigned okg21 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants