Use lodash throttle instead of debounce for updating selection change #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ianstormtaylor @thesunny Hey fellows! 🙌 Can we please merge this lovely PR? 🙏 We encountered the same issue rendering selection change highly unreliable (especially when using up and down arrows). 🙊 Or does it require further testing? 💯 |
|
Thanks @thesunny , I tested this locally and it appears to work well. Thanks for the fix! |
thallada
pushed a commit
to considerhq/slate
that referenced
this pull request
Feb 26, 2020
…ianstormtaylor#3355) * Add lodash * Switched debounce to lodash/throttle * Updated yarn.lock
pzhine
pushed a commit
to databyss-org/slate
that referenced
this pull request
May 17, 2020
…ianstormtaylor#3355) * Add lodash * Switched debounce to lodash/throttle * Updated yarn.lock
lukesmurray
pushed a commit
to lukesmurray/slate
that referenced
this pull request
Feb 5, 2021
…ianstormtaylor#3355) * Add lodash * Switched debounce to lodash/throttle * Updated yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this adding or improving a feature or fixing a bug?
Fixing a bug
What's the new behavior?
Switched slate to use
lodash/throttleinstead ofdebouncepackage for selection changes in slate.How does this change work?
I just switched the method but the main change is the throttle will execute on the leading and trailing edge of the call while debounce only executed on the trailing edge. This means that the initial change was not reflected immediately causing some bugs when we grab the selection.
NOTE: I'm not experienced with typescript. I added
@types/lodashpackage but am not sure if I did this properly, whether I grabbed the right version, or whether it's necessary at all.Have you checked that...?
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)Does this fix any issues or need any specific reviewers?
Fixes: #3338
Reviewers: @ianstormtaylor