-
Notifications
You must be signed in to change notification settings - Fork 83
Add error handler warning to update guide #2841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview of modified files: Too many files modified in a single PR, preview link list is skipped. (228 files > 100) |
@dabrt current suggestion is technically correct imho. --
-- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this caution box will be well understood when on 5.0 doc https://doc.ibexa.co/en/5.0/infrastructure_and_maintenance/performance/
!!! caution | ||
|
||
To avoid deprecations when using PHP 8.2 or 8.3, [[= product_name =]] v4.6 needs an additional error handler. | ||
The error handler is present by default for projects that started with 4.6.8 or later. | ||
For projects that started with earlier versions, you need to add the error handler manually by running the following commands: | ||
|
||
``` bash | ||
composer config extra.runtime.error_handler "\\Ibexa\\Contracts\\Core\\MVC\\Symfony\\ErrorHandler\\Php82HideDeprecationsErrorHandler" | ||
composer dump-autoload | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's clear that "update_from_4.6" is only about 4.6 and in the continuation "update_to_5.0" removes it.
But for "performance" when on 5.0 branch of our doc, this is less clear. It's not since 4.6 that this is needed, it's for 4.6 only. I would add something about 5.0 not needing this, or I would have it only on 4.6 branch but not on 5.0 branch.
f6ab20c
to
3aba2cd
Compare
Add error handler warning to update guide
Checklist