Skip to content

Conversation

dabrt
Copy link
Contributor

@dabrt dabrt commented Jul 22, 2025

Question Answer
JIRA Ticket none
Versions all
Edition all

Add error handler warning to update guide

Checklist

  • Text renders correctly
  • Text has been checked with vale

@dabrt dabrt requested a review from reithor July 22, 2025 15:12
Copy link

github-actions bot commented Jul 22, 2025

Preview of modified files: Too many files modified in a single PR, preview link list is skipped. (228 files > 100)

@reithor
Copy link
Contributor

reithor commented Jul 24, 2025

@dabrt current suggestion is technically correct imho.
Alternatively we could add the information just before https://doc.ibexa.co/en/latest/update_and_migration/from_4.6/update_from_4.6/#v461 :

--
To avoid deprecations when using PHP 8.2 or PHP 8.3, v4.6 provides an additional error handler.
If the error handler is not already present in composer.json, add the error handler by running the following commands:

composer config extra.runtime.error_handler "\\Ibexa\\Contracts\\Core\\MVC\\Symfony\\ErrorHandler\\Php82HideDeprecationsErrorHandler"
composer dump-autoload

--

@reithor reithor self-requested a review July 24, 2025 10:30
@dabrt dabrt requested a review from mnocon July 24, 2025 17:31
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@adriendupuis adriendupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this caution box will be well understood when on 5.0 doc https://doc.ibexa.co/en/5.0/infrastructure_and_maintenance/performance/

Comment on lines +55 to +65
!!! caution

To avoid deprecations when using PHP 8.2 or 8.3, [[= product_name =]] v4.6 needs an additional error handler.
The error handler is present by default for projects that started with 4.6.8 or later.
For projects that started with earlier versions, you need to add the error handler manually by running the following commands:

``` bash
composer config extra.runtime.error_handler "\\Ibexa\\Contracts\\Core\\MVC\\Symfony\\ErrorHandler\\Php82HideDeprecationsErrorHandler"
composer dump-autoload
```

Copy link
Contributor

@adriendupuis adriendupuis Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's clear that "update_from_4.6" is only about 4.6 and in the continuation "update_to_5.0" removes it.

But for "performance" when on 5.0 branch of our doc, this is less clear. It's not since 4.6 that this is needed, it's for 4.6 only. I would add something about 5.0 not needing this, or I would have it only on 4.6 branch but not on 5.0 branch.

@mnocon mnocon force-pushed the Add-error-handler-warning branch from f6ab20c to 3aba2cd Compare July 30, 2025 07:13
@mnocon mnocon changed the base branch from 5.0 to 4.6 July 30, 2025 07:13
@mnocon mnocon merged commit 95f999d into 4.6 Jul 30, 2025
7 checks passed
@mnocon mnocon deleted the Add-error-handler-warning branch July 30, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants