Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4284: Fixed accessing _type node in Item type #41

Closed
wants to merge 2 commits into from
Closed

IBX-4284: Fixed accessing _type node in Item type #41

wants to merge 2 commits into from

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Nov 10, 2022

@webhdx webhdx added Bug Something isn't working Ready for review labels Nov 10, 2022
@webhdx webhdx requested review from bdunogier and a team November 10, 2022 09:50
@webhdx webhdx self-assigned this Nov 10, 2022
@webhdx webhdx changed the base branch from main to 4.2 November 10, 2022 09:51
@konradoboza konradoboza requested a review from a team November 10, 2022 09:55
@konradoboza konradoboza requested a review from a team November 10, 2022 10:01
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx closed this Nov 10, 2022
@webhdx
Copy link
Contributor Author

webhdx commented Nov 10, 2022

Closed because now I see it is a wrong approach. It looks like GraphQL some time ago started to use Item objects but somehow we still get Content from some resolvers. It needs to be throughly reviewed and fixed.

cc @bdunogier

@bdunogier
Copy link
Collaborator

I had done a search for leftovers of that change, but some may have slipped through...

@alongosz alongosz deleted the user_item_fix branch November 10, 2022 14:43
@barw4
Copy link
Contributor

barw4 commented Feb 14, 2023

#46 - could be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunogier bdunogier bdunogier approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@webhdx webhdx

@konradoboza konradoboza

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@webhdx @bdunogier @barw4 @konradoboza @adamwojs