Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4415: Fixed createDomainContent mutation #46

Merged
merged 1 commit into from
Feb 15, 2023
Merged

IBX-4415: Fixed createDomainContent mutation #46

merged 1 commit into from
Feb 15, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Feb 14, 2023

JIRA: IBX-4415

@barw4 barw4 added Bug Something isn't working Ready for review labels Feb 14, 2023
@barw4 barw4 requested a review from a team February 14, 2023 15:47
@barw4 barw4 self-assigned this Feb 14, 2023
@barw4 barw4 mentioned this pull request Feb 14, 2023
Closed
@konradoboza konradoboza requested a review from a team February 15, 2023 08:14
webhdx
webhdx approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but Konrad has good point

@webhdx webhdx requested a review from a team February 15, 2023 08:25
@barw4 barw4 force-pushed the ibx-4415-fix-CreateDomainContent-mutation branch from ab2760c to e3a85cf Compare February 15, 2023 09:57
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Feb 15, 2023
micszo
micszo approved these changes Feb 15, 2023
View reviewed changes
Copy link

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception no longer occurs. 👍🏻

QA Approved on Ibexa Commerce 4.3.4-dev.

@micszo micszo removed their assignment Feb 15, 2023
@konradoboza konradoboza merged commit c5b618b into 4.3 Feb 15, 2023
@konradoboza konradoboza deleted the ibx-4415-fix-CreateDomainContent-mutation branch February 15, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@micszo micszo micszo approved these changes

Assignees

@adamwojs adamwojs

@webhdx webhdx

@barw4 barw4

@konradoboza konradoboza

Labels
Bug Something isn't working QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @webhdx @micszo @konradoboza @adamwojs