-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX BUG: Final solution Of 'Cannot read property ' #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
neoFelhz
approved these changes
Jun 6, 2018
idawnlight
added a commit
to idawnlight/typecho-theme-material
that referenced
this pull request
Jun 22, 2018
zsjsll
added a commit
to zsjsll/hexo-theme-material
that referenced
this pull request
Apr 13, 2021
* feat(ls): New localstorage cleanup mechanism * feat(comment): add livere comment system support. * feat(qrcode): add google qrcode api support * feat(cdn): update the config * feat(cdn): update the file load * feat(materialcdn): revert materialcdn configuration back * feat(footer): footer text customize support * feat(footer) - fix a bug of using html tag - add support for multi-line text * fix/feat(coment) - remove the livere_type config - add dns-prefetch support for 163gentie & livere - add sourceId support for 163gentie * feat(footer_sns): use raw instead of base64 * fix(footer_sns): fix some issue of value setting * feat(footer): add custom footer * fix(sdd): remove the 'index.html' in value url. * feat(head): minor changes for better performance. * feat(head): minor changes of dns-prefetch - split the dns-prefetch - add `chart.google.com` - add `custom_font_host` * feat(code highlight): google code prettify support (iblh#395) * feat(prettify): minor changes - Remove the custom_css - Add public cdn support - Only load prettify at post pages * feat:(prettify): upload theme css * feat(prettify): remove the comment of the theme css * feat(prettify): minor changes - load prettify.js only at post - import prettify_css - remove custom_css * feat(prettify): import prettify css * fix(footer): fix js.min.js import * feat(head): link alternate for rss * fix(prettify): minor fix - fix prettify being affected by other styles - fix background in prettify theme - fix prettify theme import * feat(structured-data) - type - author's avatar - mainEntityOfPage * feat(rss): improve link alternate rss type * fix(rss): fix config.feed.type * feat(fonts): import material icons as vendors * fix(fonts): avoid font loading issue with ls * feat(license): add every-post license config * fix(fonts): fix material icons import * fix(scrollbar): fix x-scroll when toTop show fix(scrollbar): fix iblh#404 * fix(fonts): fix font-awsome import * fix(background): set bing background before lazyload initialization * feat(post): update license interface * fix(scrollbar): fix x-scroll missing issue * style(css): optimize (iblh#409) * style(css): remove useless color * style(css): remove browsehappy * style(css): optimize (iblh#412) - style(css): remove useless code - style(css): compress the code * fix(comment): 163gentie config value (iblh#417) 修复配置参数 gentie_thread_key_type 引用错误 (iblh#417) * feat(head): minor changes - change lsloader & queue import - changes dns-prefetch import - fix `X-UA-Compatible` - add `format-detection` * fix(comment): try `ls-javascript` to avoid issues * fix/refactor(path): fix subdir error & refactor url concatenation - Use "url_for(path)" instead of "config.root + path" (ref: https://hexo.io/docs/helpers.html ). - Fix 404 error when site is in a subdirectory. Closes iblh#420 * fix(permission): fix permission error - remove unnecessary execution permissions. * remove(comment): remove 163 gentie * fix(MathJax): fix case so mathjax can find its own script tag ref: https://github.com/mathjax/MathJax/blob/master/unpacked/MathJax.js#L3127 Closes iblh#425 * refactor: move dnsprefetch to widget * feat: add v2ex footer icon source (iblh#432) * feat: compress the code of v2ex icon https://jakearchibald.github.io/svgomg/ * feat(config): use jsDelivr as an example * chore/feat(ci): bring up travis * feat(notag nocategory): auto detect if the post has tags/categories * feat(toc): auto detect if the post has toc or it will hide toc button * fix(burger): no longer gets error when you cant see this dude * fix: move toc detector script to footer * fix(iblh#373): support multiple analytics system * fix: cnzz site id value update * feat/chore(travis): make build more faster - remove gulp installation - set the depth of repo clone * revert: feat/chore(travis): set the depth This reverts commit 5976472 * fix(lsload): error resources type. * fix: css resources error * fix(lsload): resources error * feat(footer): add v2ex icon to layout * fix: new fallback rule for vendor config vendors -> materialcdn -> origin * fix: material icons import compatible with Google Fonts or CDN * fix: try to solve 'unexpected token' during the test * chore(travis): use Trusty as enviroment of travis * fix: fix 'unexpected token' in the test * fix: solve 'unexpected token' in the test * fix: telegram icon & v2ex icon * fix: v2ex & telegram icon * fix(footer): fix v2ex footer issue * refactor(footer):reduce accuracy on v2ex footer image * fix(footer): upload raw v2ex footer file * feat(toc): auto hide toc when generate instead of realtime js * feat(comment): add gitment * style(scrollbar): become the same as sidebar * style(scrollbar): Hidden when the mouse leaves * fix: version string error * refactor(footer_icon): add icon to style.css * refactor: remove config_footer in head * feat(comment): disqus accessible check * fix: path 'null' error when use materialcdn * revert: style(scrollbar): become the same as sidebar and auto-hidding This reverts commit 19d5355 . * ci(browserstack): using browserstack to generate preview (iblh#477) * ci(browserstack): bring up browserstack * ci(browserstack): fix test.js * ci(browserstack): remove show test.js log * ci(browserstack): add project info * ci(config): add more config * ci(browserstack): only test on desktop platfrom * ci(browserstack): set timeout * ci(browserstack): follow test.js edit * ci(browserstack): optimize * ci(browserstack): remove OSX_Opera * ci(browserstack): remove real device * ci(docsify): add docsify * ci(docsify): fix docsify * ci(docsify): fix docsify * ci(docsify): use mkdir -p * ci(docsify): fix deploy * Add Valine comment system * fix(comment): subdir path fix * fix(comment): change valine.min.js link * fix(comment):switch Valine.min.js js file to jsdelivr cdn * ci(travis): add notification * feat: add dns-prefetch for valine * fix(gitment): fixed a error * fix(css): fix css optimize fault * feat(font): add new font.host catnet * feat(hanabi): add code pretty hanabi * refactor(config): update about highlight * fix(iblh#495) * feat(hanabi): allow custom colors * feat: add materialcdn support for hanabi * style(font): add font-family for <code> tag * style(version): update version code to 1.5.0 * fix(burger): fix console error * chore(readme): update version color * chore(style): update config.template * chore(README): update render image * chore(README): minor style changes * Add option 'hide_license'. * Add option 'hide_share'. * Add option 'hide_post_info'. * fix(comment): disqus_click button issue * feat: update dns-prefetch * fix(dnsprefetch):remove 'else'. * feat(comment): add gitalk * feat(gitalk): add gitalk config * Feat(comment):update valine comment version * change cdn * feat(comment): update valine comment version (iblh#558) * feat(comment):update valine comment version * change cdn * fix(livere): add id for ls-javascript tag iblh#546 * fix(iblh#553) * merge(iblh#563): add Dutch translation 🌐 This commit adds a Dutch translation * feat(i18n): Russian import (iblh#565) * feat(icons): embedded the material_icons Try to fix iblh#459 * docs(readme): some changes * style(config): fix gittalk configurations format (iblh#569) * style: compress the search code * fix(font): fix material icons base64 * refactor: remove combo support from lsloader * refactor(head): meta info * refactor: update version code * Feat(comment):update valine comment version and add some attribute * Feat(comment):update valine comment version and add some attribute * fix(gallery): remove css async load * feat(footer_sns): add segmentfault (iblh#590) * fix(gitment): fix an error Uncomment "id",because gitment says "Error: Validation Failed" * feat/fix(copyright): avoid using document.write * feat(comment): add wildfire Signed-off-by: Love4Taylor <love4taylor.me@gmail.com> * fix(wildfire): try to fix padding issue Signed-off-by: Love4Taylor <love4taylor.me@gmail.com> * feat(gallery): add gallery settings * feat(gallery): unlock information panel * fixed(valine): fixed guest_info not working * feat: improve accessiable reading (iblh#628) * fix(typo): fix two typos in config (iblh#615) change words "form" to "from" * fix Uncaught TypeError: Cannot read property 'contains' of undefined * fix: solution Of 'Cannot read property' iblh#654 * feat (lang) : add language - korean * fix(valine): attribute configurations do not take effect * refactor: dump version * fix: clean material localstorage * fix: change cat.net to loli.net * refactor: dump version 1.5.6 * chore: update README Co-authored-by: eyhn <cneyhn@gmail.com> Co-authored-by: neoFelhz <1044010989@qq.com> Co-authored-by: neoFelhz <neofelhz@gmail.com> Co-authored-by: neoFelhz <neofelhz@github.com> Co-authored-by: zhuxiongxian <zhuxiongxian@gmail.com> Co-authored-by: cubesky <wqr3011@gmail.com> Co-authored-by: cubesky <cubesky@users.noreply.github.com> Co-authored-by: koyabr <koyabr@gmail.com> Co-authored-by: TakWolf <TakWolf@users.noreply.github.com> Co-authored-by: bloodtox3710 <bloodtox3710@users.noreply.github.com> Co-authored-by: Kanglai Qian <qiankanglai@gmail.com> Co-authored-by: Henry Heng <hrygheng@gmail.com> Co-authored-by: Halyul <xuhaoyuforever@gmail.com> Co-authored-by: ElderJames <shunjiey@hotmail.com> Co-authored-by: Dotos <yy.liu@foxmail.com> Co-authored-by: Viosey <imviosey@gmail.com> Co-authored-by: ysc3839 <yurichard3839@gmail.com> Co-authored-by: xCss <mail@xone.me> Co-authored-by: Wouter Janson <WouterJanson@users.noreply.github.com> Co-authored-by: Ilya Piatrenka <petrenko.ilia@gmail.com> Co-authored-by: Bobby Rong <rjl931189261@126.com> Co-authored-by: 汤利俊 <869058216@qq.com> Co-authored-by: Copyright³ <26130106+unstartdev@users.noreply.github.com> Co-authored-by: Love4Taylor <love4taylor.me@gmail.com> Co-authored-by: WSKaCrs <wska@mainstars.net> Co-authored-by: TLingC <xghc@foxmail.com> Co-authored-by: neo Felhz <neofelhz+github@gmail.com> Co-authored-by: Rocky <rjoacnkey@gmail.com> Co-authored-by: Windman <617674934@qq.com> Co-authored-by: wangn <3579677768@qq.com> Co-authored-by: itning <itning@itning.top> Co-authored-by: extracold1209 <extracold1209@gmail.com> Co-authored-by: lihang <lihang.lyon@gmail.com> Co-authored-by: CubeSky <max_301@live.com> Co-authored-by: Bo <ibh@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
Does this PR introduce a breaking change? (check one with "x")
Description
#651 在这个Pull requests 修复之后 添加 hexo-neat 代码压缩插件 后 又报错
检查发现是同样地点的代码问题:
检查length属性发现变成1了.
所以就打算根据ID进行查找节点
Verification steps
再次进行部署,代码正常运行,Console 没有报错