Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Do not rebuild image for publish. #205

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Do not rebuild image for publish. #205

merged 1 commit into from
Oct 20, 2022

Conversation

falkzoll
Copy link
Contributor

  • Avoid to rebuild the image before pushing it to the image repository. The distDocker target does an docker build before tagging and pushing to the image repository. Depending on how the docker cache is used, this causes a full rebuild of the image. But we want to push the already built and tested image not a newly created one. Therefore we now use the pushImage target. It only does a tag and a push without a docker build. In case the image does not exist (no build before), it will fail.

@falkzoll falkzoll requested a review from Luke-Roy-IBM October 19, 2022 14:40
Luke-Roy-IBM
Luke-Roy-IBM approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Luke-Roy-IBM Luke-Roy-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Luke-Roy-IBM Luke-Roy-IBM merged commit ca5bd6e into ibm-functions:master Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Luke-Roy-IBM Luke-Roy-IBM Luke-Roy-IBM approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@falkzoll @Luke-Roy-IBM