Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage requirejs-plugins/has to conditionally load the Intl shim. fix #20. #46

Closed
wants to merge 2 commits into from

Conversation

clmath
Copy link
Member

@clmath clmath commented Jun 17, 2014

This will allow to force the use of the shim using requirejs config like this:

require.config({
    config: {
        "requirejs-dplugins/has": {
            "Intl-api": false
        }
    }
}

This fix issue #20.

@clmath clmath changed the title Leverage requirejs-plugins/has to conditionally load the Intl shim. Leverage requirejs-plugins/has to conditionally load the Intl shim. fix #20. Jun 17, 2014
@wkeese
Copy link
Member

wkeese commented Jun 17, 2014

Can't you already force use of the shim via?

requirejs.config({
    map: {
        '*': {
            'ecma402/Intl': 'ecma402/IntlShim'
        }
    }
});

PS: It's still good for Intl.js to use has.add().

@clmath
Copy link
Member Author

clmath commented Jun 17, 2014

Yes you can (although, if I understand the documentation here correctly, it would be the other way around).

A better reason to use the has plugin is to leverage its build part.

@wkeese
Copy link
Member

wkeese commented Jun 17, 2014

OK. Then, it seems fine to me.

@wkeese wkeese mentioned this pull request Jun 19, 2014
@cjolif
Copy link
Contributor

cjolif commented Jun 19, 2014

Looks good to me as well. @JCEmmons any objection to @clmath going ahead and merging this?

@JCEmmons
Copy link
Member

I'm fine with it. Go ahead and merge...

@clmath
Copy link
Member Author

clmath commented Jun 20, 2014

Fixed with 9267dc0.

@clmath clmath closed this Jun 20, 2014
@clmath clmath deleted the hasPlugin branch June 20, 2014 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants