-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up main directory #47
Conversation
calendars directories. Fixes #28
Seems reasonable to me, except why not put all the calendar modules in the calendar directory? |
It's a subtle distinction, I suppose. The calendars directory has just the Regards, John C. Emmons From: Bill Keese notifications@github.com Seems reasonable to me, except why not put all the calendar modules in the — |
Right, I understand. Note that arguably all the files should go into the impl/ directory, since they are all part of the implementation. But since you've made a separate directory called calendar, it seems cleaner to me to put everything there. Just a matter of taste I suppose. |
One other thing: Shouldn't either Intl or IntlShim be moved to the impl/ directory? Whichever one of those files is the one that people aren't supposed to use directly. I'd suggest calling the public (top level) file Intl.js, and have it load the shim (impl/IntlShim) if necessary. |
No - Both Intl.js and IntlShim.js should be in the main. It's OK to use Regards, John C. Emmons From: Bill Keese notifications@github.com One other thing: Shouldn't either Intl or IntlShim be moved to the impl/ I'd suggest calling the public (top level) file Intl.js, and have it load — |
Merged... |
Remove clutter from main directory by moving .js files to either impl or calendars directories. Fixes #28