Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up main directory #47

Closed
wants to merge 1 commit into from
Closed

Clean up main directory #47

wants to merge 1 commit into from

Conversation

JCEmmons
Copy link
Member

Remove clutter from main directory by moving .js files to either impl or calendars directories. Fixes #28

@wkeese
Copy link
Member

wkeese commented Jun 18, 2014

Seems reasonable to me, except why not put all the calendar modules in the calendar directory?

@JCEmmons
Copy link
Member Author

It's a subtle distinction, I suppose. The calendars directory has just the
various supported calendars, not the generalized functions that happen to
pertain to calendars.

Regards,

John C. Emmons
Globalization Architect & Unicode CLDR TC Chairman
IBM Software Group
Internet: emmo@us.ibm.com

From: Bill Keese notifications@github.com
To: ibm-js/ecma402 ecma402@noreply.github.com,
Cc: John Emmons/Austin/IBM@IBMUS
Date: 06/18/2014 04:09 PM
Subject: Re: [ecma402] Clean up main directory (#47)

Seems reasonable to me, except why not put all the calendar modules in the
calendar directory?


Reply to this email directly or view it on GitHub.

@wkeese
Copy link
Member

wkeese commented Jun 18, 2014

Right, I understand. Note that arguably all the files should go into the impl/ directory, since they are all part of the implementation. But since you've made a separate directory called calendar, it seems cleaner to me to put everything there. Just a matter of taste I suppose.

@wkeese
Copy link
Member

wkeese commented Jun 18, 2014

One other thing: Shouldn't either Intl or IntlShim be moved to the impl/ directory? Whichever one of those files is the one that people aren't supposed to use directly.

I'd suggest calling the public (top level) file Intl.js, and have it load the shim (impl/IntlShim) if necessary.

@JCEmmons
Copy link
Member Author

No - Both Intl.js and IntlShim.js should be in the main. It's OK to use
Intl.js directly if you want the IBM implementation always, or IntlShim if
you want to leverage any native support that exists. I don't see having
both in the top level directory as being a problem.

Regards,

John C. Emmons
Globalization Architect & Unicode CLDR TC Chairman
IBM Software Group
Internet: emmo@us.ibm.com

From: Bill Keese notifications@github.com
To: ibm-js/ecma402 ecma402@noreply.github.com,
Cc: John Emmons/Austin/IBM@IBMUS
Date: 06/18/2014 05:08 PM
Subject: Re: [ecma402] Clean up main directory (#47)

One other thing: Shouldn't either Intl or IntlShim be moved to the impl/
directory? Whichever one of those files is the one that people aren't
supposed to use directly.

I'd suggest calling the public (top level) file Intl.js, and have it load
the shim (impl/IntlShim) if necessary.


Reply to this email directly or view it on GitHub.

@wkeese
Copy link
Member

wkeese commented Jun 19, 2014

Well, as @clmath explained in #46 and #20, the standard way to control that is through a has() flag. I don't see any reason to provide two official methods. (Plus which code could still always load impl/IntlShim if it really wanted to.)

@JCEmmons
Copy link
Member Author

Merged...

@JCEmmons JCEmmons closed this Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluttered root directory
2 participants