Skip to content

[patch] prevent mongo upgrade when featureCompatibilityVersion is not defined or set incorrectly #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[patch] prevent mongo upgrade when featureCompatibilityVersion is not defined or set incorrectly #1544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a3641e
[patch] prevent mongo upgrade when featureCompatibilityVersion is not…
Nov 5, 2024
1ac7946
[patch] fixed trailing-space
Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ibm/mas_devops/roles/mongodb/tasks/providers/community/validate-upgrade.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
that: "existing_mongo_version is version_compare(target_mongodb_version, '<=')"
fail_msg: "Mongo downgrade is not allowed! Current mongo version: {{ existing_mongo_version }}, target mongo version {{ target_mongodb_version }}"

# For users installed or upgraded to mongo v4.4 using old CLI didn't have featureCompatibilityVersion set correctly.
- name: Assert featureCompatibilityVersion is present and equal to existing version.
assert:
that:
- existing_mongodb.resources[0].spec.featureCompatibilityVersion is defined and existing_mongodb.resources[0].spec.featureCompatibilityVersion != ""
- existing_mongodb.resources[0].spec.featureCompatibilityVersion == existing_mongo_minor_version
fail_msg: "Mongo upgrade is not allowed due to either missing featureCompatibilityVersion field or wrong version in featureCompatibilityVersion field in MongoDBCommunity CR"
when: mongodb_v5_upgrade or mongodb_v6_upgrade or mongodb_v7_upgrade


# Only allow Mongo upgrades to be next compatible minor version
- name: "Assert Mongo upgrade compatibility: {{ target_mongodb_version }} must be in {{ mongo_compatible_target_version[existing_mongo_version] }}"
when: existing_mongo_minor_version != '4.2' # will skip this assertion if mongo v4.2 as we'll assist in the auto upgrade to v4.4 and v5 in a single run
Expand Down
Loading